pan3793 commented on code in PR #1801:
URL:
https://github.com/apache/incubator-celeborn/pull/1801#discussion_r1289503134
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/memory/MemoryManager.java:
##########
@@ -120,7 +120,12 @@ private MemoryManager(CelebornConf conf) {
.<Long>invoke();
Preconditions.checkArgument(maxDirectorMemory > 0);
- Preconditions.checkArgument(pauseReplicateRatio > pausePushDataRatio);
+ Preconditions.checkArgument(
+ pauseReplicateRatio > pausePushDataRatio,
+ String.format(
+ "Invalid config, {} should be greater than {}",
Review Comment:
let's also mention the value in the error message
```suggestion
"Invalid config, {}({}) should be greater than {}({})",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
