FMX commented on PR #1803:
URL:
https://github.com/apache/incubator-celeborn/pull/1803#issuecomment-1674137622
> Would you mind updating the file `project/CelebornBuild.scala`, following
the same rule as we do in the Flink assembly project?
>
> ```diff
> val cp = (assembly / fullClasspath).value
> cp filter { v =>
> val name = v.data.getName
> - !(name.startsWith("celeborn-") ||
name.startsWith("protobuf-java-") ||
> - name.startsWith("guava-") || name.startsWith("netty-") ||
name.startsWith("commons-lang3-"))
> + !(name.startsWith("celeborn-") ||
> + name.startsWith("protobuf-java-") ||
> + name.startsWith("guava-") ||
> + name.startsWith("netty-") ||
> + name.startsWith("commons-lang3-") ||
> + name.startsWith("RoaringBitmap-"))
> }
> },
>
> ShadeRule.rename("com.google.protobuf.**" ->
"org.apache.celeborn.shaded.com.google.protobuf.@1").inAll,
> ShadeRule.rename("com.google.common.**" ->
"org.apache.celeborn.shaded.com.google.common.@1").inAll,
> ShadeRule.rename("io.netty.**" ->
"org.apache.celeborn.shaded.io.netty.@1").inAll,
> - ShadeRule.rename("org.apache.commons.**" ->
"org.apache.celeborn.shaded.org.apache.commons.@1").inAll
> + ShadeRule.rename("org.apache.commons.**" ->
"org.apache.celeborn.shaded.org.apache.commons.@1").inAll,
> + ShadeRule.rename("org.roaringbitmap.**" ->
"org.apache.celeborn.shaded.org.roaringbitmap.@1").inAll
> ),
>
> (assembly / assemblyMergeStrategy) := {
> ```
OK，I‘ll update it.
> BTW, NOTICE for the shaded module should be updated too
RoaringBitmap has no notice and its using Apache Licencese V2. We already
contains its license info in LICENSE-binary file.
> Would you mind updating the file `project/CelebornBuild.scala`, following
the same rule as we do in the Flink assembly project?
>
> ```diff
> val cp = (assembly / fullClasspath).value
> cp filter { v =>
> val name = v.data.getName
> - !(name.startsWith("celeborn-") ||
name.startsWith("protobuf-java-") ||
> - name.startsWith("guava-") || name.startsWith("netty-") ||
name.startsWith("commons-lang3-"))
> + !(name.startsWith("celeborn-") ||
> + name.startsWith("protobuf-java-") ||
> + name.startsWith("guava-") ||
> + name.startsWith("netty-") ||
> + name.startsWith("commons-lang3-") ||
> + name.startsWith("RoaringBitmap-"))
> }
> },
>
> ShadeRule.rename("com.google.protobuf.**" ->
"org.apache.celeborn.shaded.com.google.protobuf.@1").inAll,
> ShadeRule.rename("com.google.common.**" ->
"org.apache.celeborn.shaded.com.google.common.@1").inAll,
> ShadeRule.rename("io.netty.**" ->
"org.apache.celeborn.shaded.io.netty.@1").inAll,
> - ShadeRule.rename("org.apache.commons.**" ->
"org.apache.celeborn.shaded.org.apache.commons.@1").inAll
> + ShadeRule.rename("org.apache.commons.**" ->
"org.apache.celeborn.shaded.org.apache.commons.@1").inAll,
> + ShadeRule.rename("org.roaringbitmap.**" ->
"org.apache.celeborn.shaded.org.roaringbitmap.@1").inAll
> ),
>
> (assembly / assemblyMergeStrategy) := {
> ```
I'll update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
