waitinfuture commented on PR #1807: URL: https://github.com/apache/incubator-celeborn/pull/1807#issuecomment-1676667156
Hi @pan3793 @cfmcgrady , I thought about this and still can't get the point why previously `multiple threads invoking SortBasedPusher#triggerPush simultaneously` will happen, could you explain it in more detail? According to https://docs.oracle.com/javase/tutorial/essential/concurrency/atomic.html cc @FMX , `volatile` guarantees atomicity and happens before, so IMO `volatile` is capable for the pushing logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
