waitinfuture commented on code in PR #1826:
URL:
https://github.com/apache/incubator-celeborn/pull/1826#discussion_r1302528362
##########
charts/celeborn/values.yaml:
##########
@@ -53,28 +53,28 @@ volumes:
- mountPath: /mnt/celeborn_ratis
hostPath: /mnt/celeborn_ratis
type: hostPath
- size: 1Gi
+ capacity: 1Gi
Review Comment:
I'm not sure, but 1GiB might be too small?
##########
charts/celeborn/values.yaml:
##########
@@ -53,28 +53,28 @@ volumes:
- mountPath: /mnt/celeborn_ratis
hostPath: /mnt/celeborn_ratis
type: hostPath
- size: 1Gi
+ capacity: 1Gi
worker:
- mountPath: /mnt/disk1
hostPath: /mnt/disk1
type: hostPath
diskType: HDD
Review Comment:
Shall we set default diskType to SSD? As we already set default value of
`celeborn.worker.flusher.threads` to 16, the same with ssd's flusher threads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
