ulysses-you opened a new pull request, #1838:
URL: https://github.com/apache/incubator-celeborn/pull/1838
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
When updating record read metric, we should consider if the input record is
`ColumnarBatch`. So if the serde is the Gluten columnar batch, we should use
`ColumnarBatch.numRows`.
### Why are the changes needed?
Make the shuffle record read metric correct.
### Does this PR introduce _any_ user-facing change?
yes, the metrics changed
### How was this patch tested?
manually test
before:
<img width="415" alt="image"
src="https://github.com/apache/incubator-celeborn/assets/12025282/221ab814-4b02-4688-80ab-31f21cd900a4";>
after:
<img width="415" alt="image"
src="https://github.com/apache/incubator-celeborn/assets/12025282/1c7257c0-2f30-41c3-9ea8-6bc5cda3de85";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
