cfmcgrady commented on code in PR #1844:
URL:
https://github.com/apache/incubator-celeborn/pull/1844#discussion_r1306885270
##########
project/CelebornBuild.scala:
##########
@@ -492,30 +492,6 @@ object Spark34 extends SparkClientProjects {
val sparkVersion = "3.4.1"
val zstdJniVersion = "1.5.2-5"
-
- lazy val deps = Seq(
- // Spark Use `log4j-slf4j2-impl` instead of `log4j-slf4j-impl` in
SPARK-40511
- // to fix the error:
- // ```
- // java.lang.NoSuchMethodError:
org.apache.logging.slf4j.Log4jLoggerFactory.<init>(Lorg/apache/logging/slf4j/Log4jMarkerFactory;)V
- // ```
- "org.apache.logging.log4j" % "log4j-slf4j2-impl" % "2.19.0" % "test"
Review Comment:
it is not found in the current dependency tree.
```
$ ./build/sbt -Pspark-3.4 celeborn-client-spark-3/Test/dependencyTree | grep
log4j-slf4j
[info] | | +-org.apache.logging.log4j:log4j-slf4j-impl:2.17.2
[info] | +-org.apache.logging.log4j:log4j-slf4j-impl:2.17.2
[info] | +-org.apache.logging.log4j:log4j-slf4j-impl:2.17.2
[info] | | | +-org.apache.logging.log4j:log4j-slf4j-impl:2.17.2
[info] | | +-org.apache.logging.log4j:log4j-slf4j-impl:2.17.2
[info] | +-org.apache.logging.log4j:log4j-slf4j-impl:2.17.2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
