SteNicholas commented on code in PR #1814:
URL:
https://github.com/apache/incubator-celeborn/pull/1814#discussion_r1308167846
##########
client-spark/spark-2/src/main/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleFallbackPolicyRunner.scala:
##########
@@ -25,7 +25,7 @@ class CelebornShuffleFallbackPolicyRunner(conf: CelebornConf)
extends Logging {
def applyAllFallbackPolicy(lifecycleManager: LifecycleManager,
numPartitions: Int): Boolean = {
applyForceFallbackPolicy() ||
applyShufflePartitionsFallbackPolicy(numPartitions) ||
- !checkQuota(lifecycleManager)
+ !checkQuota(lifecycleManager) || !checkWorkersAvailable(lifecycleManager)
Review Comment:
Note: check quota should set `celeborn.quota.enabled` to true. Therefore
check workers available should not check with quota.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
