SteNicholas commented on code in PR #1851: URL: https://github.com/apache/incubator-celeborn/pull/1851#discussion_r1308204576
########## CONTRIBUTING.md: ########## @@ -33,3 +33,8 @@ There are already some further improvements on the schedule and welcome to conta 8. Enhanced K8S support. 9. Support spilled data. 10. Locality awareness. + +## Guidelines +### Adding RPC Messages +We are in the process of replacing case class wrappers for RPC messages with raw PB. If you are to add new Review Comment: ``` When you adds new RPC message, it's recommended to follow raw PB message case, for example `RegisterWorker` and `RegisterWorkerResponse`. The RPC messages will be unified into raw PB messages eventually. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
