zhouyifan279 commented on code in PR #1843:
URL:
https://github.com/apache/incubator-celeborn/pull/1843#discussion_r1308382932
##########
client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkShuffleManager.java:
##########
@@ -304,17 +309,8 @@ public <K, C> ShuffleReader<K, C> getReaderForRange(
TaskContext context,
ShuffleReadMetricsReporter metrics) {
if (handle instanceof CelebornShuffleHandle) {
- @SuppressWarnings("unchecked")
- CelebornShuffleHandle<K, ?, C> h = (CelebornShuffleHandle<K, ?, C>)
handle;
- return new CelebornShuffleReader<>(
- h,
- startPartition,
- endPartition,
- startMapIndex,
- endMapIndex,
- context,
- celebornConf,
- metrics);
+ return getCelebornShuffleReader(
+ handle, startPartition, endPartition, startMapIndex, endMapIndex,
context, metrics);
Review Comment:
I created a new PR #1853 to unify the order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
