waitinfuture commented on code in PR #1853:
URL:
https://github.com/apache/incubator-celeborn/pull/1853#discussion_r1308851622
##########
client-spark/spark-3/src/main/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleReader.scala:
##########
@@ -30,10 +30,10 @@ import org.apache.celeborn.common.CelebornConf
class CelebornShuffleReader[K, C](
handle: CelebornShuffleHandle[K, _, C],
- startPartition: Int,
- endPartition: Int,
startMapIndex: Int = 0,
endMapIndex: Int = Int.MaxValue,
+ startPartition: Int,
+ endPartition: Int,
Review Comment:
😭😭😭 Which api does Gluten celeborn shuffle manager rely on? It ok if we
consistently make start/end partitions before map indices?
##########
client-spark/spark-3/src/main/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleReader.scala:
##########
@@ -30,10 +30,10 @@ import org.apache.celeborn.common.CelebornConf
class CelebornShuffleReader[K, C](
handle: CelebornShuffleHandle[K, _, C],
- startPartition: Int,
- endPartition: Int,
startMapIndex: Int = 0,
endMapIndex: Int = Int.MaxValue,
+ startPartition: Int,
+ endPartition: Int,
Review Comment:
😭😭😭 Which api does Gluten celeborn shuffle manager rely on? It ok if we
consistently make start/end partitions before map indices? cc @kerwin-zk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
