waitinfuture opened a new pull request, #1876:
URL: https://github.com/apache/incubator-celeborn/pull/1876
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
This PR fixes performance degradation when Spark's coalescePartitions takes
effect caused
by RPC latency.
### Why are the changes needed?
I encountered a performance degradation when testing tpcds 10T q10:
||Time|
|---|---|
|ESS|14s|
|Celeborn| 24s|
After digging into it I found out that q10 triggers partition coalescence:
As I configured `spark.sql.adaptive.coalescePartitions.minPartitionNum` to
1000, `CelebornShuffleReader`
will call `shuffleClient.readPartition` sequentially 1000 times, causing the
delay.
This PR optimizes by calling `shuffleClient.readPartition` in parallel.
### Does this PR introduce _any_ user-facing change?
No, but introduced a new client side configuration
`celeborn.client.streamCreatorPool.threads`
which defaults to 32.
### How was this patch tested?
TPCDS 1T and passes GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
