waitinfuture commented on code in PR #1863:
URL: 
https://github.com/apache/incubator-celeborn/pull/1863#discussion_r1319737951


##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/MetaHandler.java:
##########
@@ -141,16 +141,6 @@ public ResourceResponse 
handleWriteRequest(ResourceProtos.ResourceRequest reques
           metaSystem.updateWorkerLostMeta(host, rpcPort, pushPort, fetchPort, 
replicatePort);
           break;
 
-        case WorkerRemove:

Review Comment:
   For back compatibility, I think we can't remove `WorkerRemove` msg, or it 
will throw Exception. We need to remain this message for at least one minor 
version. We can delete the case block.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to