pan3793 commented on code in PR #1824:
URL:
https://github.com/apache/incubator-celeborn/pull/1824#discussion_r1320185259
##########
sbin/load-celeborn-env.sh:
##########
@@ -69,3 +69,24 @@ if [ "$CELEBORN_PID_DIR" = "" ]; then
export CELEBORN_PID_DIR="${CELEBORN_HOME}/pids"
fi
+# jemalloc memory allocator is enabled by default, you may set
DISABLE_JEMALLOC to true in celeborn-env.sh if it's not as you wish.
Review Comment:
sound reasonable. how about
1) make `PREFER_JEMALLOC` and `JEMALLOC_PATH` configurable in
`celeborn-env.sh`
2) disable `PREFER_JEMALLOC` by default, at least for `branch-0.3`, we may
enable it by default in the future
3) consider the adoption rate of Linux distribution, when
`PREFER_JEMALLOC=true` and `JEMALLOC_PATH` is absent, search the default
installed path of jemalloc libraries on Debian and CentOS 7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
