waitinfuture commented on code in PR #1800:
URL:
https://github.com/apache/incubator-celeborn/pull/1800#discussion_r1322492302
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/memory/MemoryManager.java:
##########
@@ -66,7 +68,10 @@ public class MemoryManager {
private final LongAdder pausePushDataCounter = new LongAdder();
private final LongAdder pausePushDataAndReplicateCounter = new LongAdder();
private ServingState servingState = ServingState.NONE_PAUSED;
+ private long pauseStartTime = -1L;
+ private long pausePushDataTime = 0L;
private volatile boolean isPaused = false;
+ private final AtomicInteger trimCounter = new AtomicInteger(0);
Review Comment:
Does trimCounter need to be atomic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
