pan3793 commented on code in PR #1830:
URL:
https://github.com/apache/incubator-celeborn/pull/1830#discussion_r1323898648
##########
README.md:
##########
@@ -41,41 +41,31 @@ Celeborn Worker's slot count is decided by `total usable
disk size / average shu
Celeborn worker's slot count decreases when a partition is allocated and
increments when a partition is freed.
## Build
-1.Celeborn supports Spark 2.4/3.0/3.1/3.2/3.3/3.4 and flink 1.14/1.15/1.17.
+1.Celeborn supports Spark 2.4/3.0/3.1/3.2/3.3/3.4 and flink 1.14/1.15/1.17 and
Hadoop 2/3.
2.Celeborn tested under Java 8 environment.
Build Celeborn
```shell
-./build/make-distribution.sh
-Pspark-2.4/-Pspark-3.0/-Pspark-3.1/-Pspark-3.2/-Pspark-3.3/-Pspark-3.4/-Pflink-1.14/-Pflink-1.15/-Pflink-1.17
+./build/make-distribution.sh
-Pspark-2.4/-Pspark-3.0/-Pspark-3.1/-Pspark-3.2/-Pspark-3.3/-Pspark-3.4/-Pflink-1.14/-Pflink-1.15/-Pflink-1.17/-Pmr
```
package apache-celeborn-${project.version}-bin.tgz will be generated.
### Package Details
Build procedure will create a compressed package.
-Spark package layout:
+General package layout:
```
├── RELEASE
├── bin
├── conf
├── jars // common jars for master and worker
├── master-jars
├── worker-jars
- ├── sbin
- └── spark // Spark client jars
-```
-
-Flink package layout:
-```
- ├── RELEASE
- ├── bin
- ├── conf
- ├── jars // common jars for master and worker
- ├── master-jars
- ├── worker-jars
- ├── sbin
- └── flink // flink client jars
+ ├── spark // Spark client jars if spark profiles are activated
+ ├── flink // flink client jars if flink profiles are activated
+ ├── mr // mr client jars if hadoop profiles are activated
Review Comment:
```suggestion
├── spark // Spark client jars if spark profiles are activated
├── flink // Flink client jars if flink profiles are activated
├── mr // MapReduce client jars if mr profile is activated
```
##########
README.md:
##########
@@ -41,41 +41,31 @@ Celeborn Worker's slot count is decided by `total usable
disk size / average shu
Celeborn worker's slot count decreases when a partition is allocated and
increments when a partition is freed.
## Build
-1.Celeborn supports Spark 2.4/3.0/3.1/3.2/3.3/3.4 and flink 1.14/1.15/1.17.
+1.Celeborn supports Spark 2.4/3.0/3.1/3.2/3.3/3.4 and flink 1.14/1.15/1.17 and
Hadoop 2/3.
2.Celeborn tested under Java 8 environment.
Build Celeborn
```shell
-./build/make-distribution.sh
-Pspark-2.4/-Pspark-3.0/-Pspark-3.1/-Pspark-3.2/-Pspark-3.3/-Pspark-3.4/-Pflink-1.14/-Pflink-1.15/-Pflink-1.17
+./build/make-distribution.sh
-Pspark-2.4/-Pspark-3.0/-Pspark-3.1/-Pspark-3.2/-Pspark-3.3/-Pspark-3.4/-Pflink-1.14/-Pflink-1.15/-Pflink-1.17/-Pmr
```
package apache-celeborn-${project.version}-bin.tgz will be generated.
### Package Details
Build procedure will create a compressed package.
-Spark package layout:
+General package layout:
```
├── RELEASE
├── bin
├── conf
├── jars // common jars for master and worker
├── master-jars
├── worker-jars
- ├── sbin
- └── spark // Spark client jars
-```
-
-Flink package layout:
-```
- ├── RELEASE
- ├── bin
- ├── conf
- ├── jars // common jars for master and worker
- ├── master-jars
- ├── worker-jars
- ├── sbin
- └── flink // flink client jars
+ ├── spark // Spark client jars if spark profiles are activated
+ ├── flink // flink client jars if flink profiles are activated
+ ├── mr // mr client jars if hadoop profiles are activated
Review Comment:
```suggestion
├── spark // Spark client jars if spark profiles are activated
├── flink // Flink client jars if flink profiles are activated
├── mr // MapReduce client jars if mr profile is activated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
