waitinfuture commented on code in PR #1978:
URL: 
https://github.com/apache/incubator-celeborn/pull/1978#discussion_r1357725876


##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportResponseHandler.java:
##########
@@ -70,6 +70,8 @@ public class TransportResponseHandler extends 
MessageHandler<ResponseMessage> {
   private static ScheduledExecutorService fetchTimeoutChecker = null;
   private ScheduledFuture fetchCheckerScheduleFuture;
 
+  private final Object handleFailureLock = new Object();

Review Comment:
   @onebox-li They are already `ConcurrentHashMap`, see
   ```
       this.outstandingFetches = JavaUtils.newConcurrentHashMap();
       this.outstandingRpcs = JavaUtils.newConcurrentHashMap();
       this.outstandingPushes = JavaUtils.newConcurrentHashMap();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to