onebox-li commented on code in PR #2003:
URL:
https://github.com/apache/incubator-celeborn/pull/2003#discussion_r1365521951
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -381,8 +381,17 @@ class CelebornConf(loadDefaults: Boolean) extends
Cloneable with Logging with Se
new RpcTimeout(get(RPC_LOOKUP_TIMEOUT).milli, RPC_LOOKUP_TIMEOUT.key)
def rpcAskTimeout: RpcTimeout =
new RpcTimeout(get(RPC_ASK_TIMEOUT).milli, RPC_ASK_TIMEOUT.key)
- def rpcDispatcherNumThreads(availableCores: Int): Int =
- get(RPC_DISPATCHER_THREADS).getOrElse(availableCores)
+ def rpcDispatcherNumThreads(availableCores: Int): Int = {
+ val num = get(RPC_DISPATCHER_THREADS)
Review Comment:
I think it can’t. It is a fallback condition in this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
