kerwin-zk commented on PR #2055: URL: https://github.com/apache/incubator-celeborn/pull/2055#issuecomment-1784890606
> We can refactor the `initializeMemoryAllocator` function to eliminate its dependency on the member variable `TransportClientFactory#conf`. This will allow us to safely remove the `TransportClientFactory#conf` member variable, to prevent performance degradation resulting from erroneous `TransportClientFactory#conf` utilization. @cfmcgrady Currently, it appears that the 'TransportClientFactory#conf' is mainly used during the initialization of 'TransportClientFactory' and is called only once. Therefore, there is no additional overhead from multiple invocations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
