RexXiong commented on code in PR #2075:
URL:
https://github.com/apache/incubator-celeborn/pull/2075#discussion_r1385982375
##########
client/src/main/scala/org/apache/celeborn/client/ApplicationHeartbeater.scala:
##########
@@ -96,8 +99,31 @@ class ApplicationHeartbeater(
}
}
+ private def unregisterApplication(): Unit = {
+ try {
+ // Then unregister Application
+ val response = masterClient.askSync[ApplicationLostResponse](
+ ApplicationLost(appId),
+ classOf[ApplicationLostResponse])
+ logInfo(s"Unregister Application $appId with response status:
${response.status}")
+ } catch {
+ case e: Exception =>
+ logWarning("AskSync unRegisterApplication failed.", e)
+ }
+ }
+
def stop(): Unit = {
- appHeartbeat.cancel(true)
- ThreadUtils.shutdown(appHeartbeatHandlerThread, 800.millis)
+ stopped.synchronized {
+ if (!stopped) {
+ // Stop appHeartbeat first
+ logInfo(s"Stop Application heartbeat $appId")
+ appHeartbeat.cancel(true)
+ ThreadUtils.shutdown(appHeartbeatHandlerThread, 800.millis)
+ if (applicationUnregisterEnabled) {
Review Comment:
> Why do we need to introduce a configuration to control the activation of
this feature?
Disable this can keep shuffle files a while, which can be used for debugging
scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
