waitinfuture commented on code in PR #2071:
URL:
https://github.com/apache/incubator-celeborn/pull/2071#discussion_r1385983756
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -1195,8 +1198,10 @@ class PushDataHandler(val workerSource: WorkerSource)
extends BaseMessageHandler
val diskInfo = workerInfo.diskInfos
.get(fileWriter.flusher.asInstanceOf[LocalFlusher].mountPoint)
+ val minimumUsableSize =
Review Comment:
Hi @SteNicholas , `DiskUtils.getMinimumUsableSize` is costly, IMO we'd
better to cache `minimumUsableSize` in a variable instead of calculate for
every pushdata. cc @FMX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
