waitinfuture commented on code in PR #2083:
URL:
https://github.com/apache/incubator-celeborn/pull/2083#discussion_r1386592757
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -1195,14 +1198,13 @@ class PushDataHandler(val workerSource: WorkerSource)
extends BaseMessageHandler
if (fileWriter.flusher.isInstanceOf[HdfsFlusher]) {
return false
}
- val diskInfo = workerInfo.diskInfos
- .get(fileWriter.flusher.asInstanceOf[LocalFlusher].mountPoint)
-
- val minimumUsableSize =
- DiskUtils.getMinimumUsableSize(diskInfo, diskReserveSize,
diskReserveRatio)
+ val mountPoint = fileWriter.flusher.asInstanceOf[LocalFlusher].mountPoint
+ val diskInfo = workerInfo.diskInfos.get(mountPoint)
+ diskUsableSizes.putIfAbsent(
Review Comment:
I think it's better to calculate the map in `init()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
