onebox-li commented on code in PR #2086:
URL:
https://github.com/apache/incubator-celeborn/pull/2086#discussion_r1395497213
##########
common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala:
##########
@@ -232,8 +232,12 @@ class WorkerInfo(
}
override def hashCode(): Int = {
- val state = Seq(host, rpcPort, pushPort, fetchPort, replicatePort)
- state.map(_.hashCode()).foldLeft(0)((a, b) => 31 * a + b)
+ var result = host.hashCode()
+ result = 31 * result + rpcPort.hashCode()
+ result = 31 * result + pushPort.hashCode()
+ result = 31 * result + fetchPort.hashCode()
+ result = 31 * result + replicatePort.hashCode()
+ result
Review Comment:
The calculation here is relatively cheap, and the cache will not be much
improved, so we may make it simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
