otterc commented on PR #2105: URL: https://github.com/apache/incubator-celeborn/pull/2105#issuecomment-1819649557
> Given the size of the PR, to aid in easier review, can we split this up ? For example: > > * Changes to existing interfaces, and their tests (`BaseMessageHandler`, `TransportClientFactory `, etc) - which enables the specific changes. > * proto changes and serde for it. > * Split the server and client side changes for sasl. > > * A test which does end to end will have to wait for both to land. > * Support for specific sasl mechanism(s) > * Anything else remaining ? > > We can keep the current PR open as DRAFT, and reference it in the individual PR's so that reviewers have overall context about the work. > > Thoughts ? Sure, I can break it up as suggested. I will convert this PR to a DRAFT and create smaller PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
