SteNicholas commented on code in PR #2108:
URL:
https://github.com/apache/incubator-celeborn/pull/2108#discussion_r1401516825
##########
master/src/test/java/org/apache/celeborn/service/deploy/master/SlotsAllocatorSuiteJ.java:
##########
@@ -334,4 +334,16 @@ public void testHDFSOnly() {
final boolean shouldReplicate = true;
checkSlotsOnHDFS(workers, partitionIds, shouldReplicate, true);
}
+
+ @Test
+ public void testAllocateSlotsWithNoAvailableSlots() {
+ final List<WorkerInfo> workers = prepareWorkers(true);
+ // Simulates no available slots behavior with greatly changed
estimatedPartitionSize for workers
+ // with usable disks.
+ workers.forEach(workerInfo ->
workerInfo.updateDiskMaxSlots(Long.MAX_VALUE));
Review Comment:
@FMX, this test cases invoke `updateDiskMaxSlots(estimatedPartitionSize)` to
set the max slots to zero and offer slots to partition which id is zero. This
test case verifies whether fallback to roundrobin works well with no available
slots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
