FMX commented on code in PR #2107:
URL:
https://github.com/apache/incubator-celeborn/pull/2107#discussion_r1401610768
##########
common/src/main/scala/org/apache/celeborn/common/rpc/netty/Inbox.scala:
##########
@@ -218,7 +218,21 @@ private[celeborn] class Inbox(
/**
* Calls action closure, and calls the endpoint's onError function in the
case of exceptions.
*/
- private def safelyCall(endpoint: RpcEndpoint)(action: => Unit): Unit = {
+ private def safelyCall(
+ endpoint: RpcEndpoint,
+ endpointRef: NettyRpcEndpointRef)(action: => Unit): Unit = {
Review Comment:
Here is no need to pass NettyRpcEndpointRef here. I think pass
NettyRpcEndpointRef.name could be OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
