AngersZhuuuu commented on code in PR #1232:
URL:
https://github.com/apache/incubator-celeborn/pull/1232#discussion_r1402018142
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/celeborn/SortBasedPusher.java:
##########
@@ -316,11 +379,7 @@ private void allocateMemoryForRecordIfNecessary(int
required) throws IOException
@Override
public long spill(long l, MemoryConsumer memoryConsumer) throws IOException {
- logger.info("Pushdata in spill, memory used " + getUsed());
- if (getUsed() != 0) {
- logger.info("Pushdata is not empty , do push.");
- return pushData();
- }
+ logger.warn("SortBasedPusher not support spill yet");
Review Comment:
We meet a case of NPE in old code, I think after this pr won't meet this
issue. If keep `pushData` here, should add some loc to keep it safe
```
java.lang.NullPointerException
at
org.apache.spark.memory.TaskMemoryManager.getPage(TaskMemoryManager.java:407)
at
org.apache.spark.shuffle.rss.SortBasedPusher.pushData(SortBasedPusher.java:155)
at
org.apache.spark.shuffle.rss.SortBasedPusher.spill(SortBasedPusher.java:317)
at
org.apache.spark.memory.TaskMemoryManager.acquireExecutionMemory(TaskMemoryManager.java:177)
at
org.apache.spark.memory.TaskMemoryManager.allocatePage(TaskMemoryManager.java:297)
at
org.apache.spark.memory.MemoryConsumer.allocatePage(MemoryConsumer.java:116)
at
org.apache.spark.sql.execution.python.HybridRowQueue.createNewQueue(RowQueue.scala:228)
at
org.apache.spark.sql.execution.python.HybridRowQueue.add(RowQueue.scala:251)
at
org.apache.spark.sql.execution.python.EvalPythonExec.$anonfun$doExecute$10(EvalPythonExec.scala:125)
at scala.collection.Iterator$$anon$10.next(Iterator.scala:461)
at scala.collection.Iterator$$anon$10.next(Iterator.scala:461)
at
scala.collection.Iterator$GroupedIterator.takeDestructively(Iterator.scala:1161)
at scala.collection.Iterator$GroupedIterator.go(Iterator.scala:1176)
at scala.collection.Iterator$GroupedIterator.fill(Iterator.scala:1214)
at scala.collection.Iterator$GroupedIterator.hasNext(Iterator.scala:1217)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
