jiaoqingbo commented on code in PR #2061:
URL:
https://github.com/apache/incubator-celeborn/pull/2061#discussion_r1407329832
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -275,6 +276,12 @@ private[celeborn] class Worker(
private val userResourceConsumptions =
JavaUtils.newConcurrentHashMap[UserIdentifier, (ResourceConsumption,
Long)]()
+ private var jvmQuake: JVMQuake = _
+ if (conf.workerJvmQuakeEnabled) {
+ jvmQuake = JVMQuake.create(conf, workerInfo.toUniqueId().replace(":", "-"))
+ jvmQuake.start()
+ }
Review Comment:
jvmQuake.start() also check conf.workerJvmQuakeEnabled，redundant
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -275,6 +276,12 @@ private[celeborn] class Worker(
private val userResourceConsumptions =
JavaUtils.newConcurrentHashMap[UserIdentifier, (ResourceConsumption,
Long)]()
+ private var jvmQuake: JVMQuake = _
+ if (conf.workerJvmQuakeEnabled) {
+ jvmQuake = JVMQuake.create(conf, workerInfo.toUniqueId().replace(":", "-"))
+ jvmQuake.start()
+ }
Review Comment:
jvmQuake.start() also check conf.workerJvmQuakeEnabled，redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
