SteNicholas commented on code in PR #2118:
URL:
https://github.com/apache/incubator-celeborn/pull/2118#discussion_r1407776642
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -3213,6 +3214,14 @@ object CelebornConf extends Logging {
.timeConf(TimeUnit.MILLISECONDS)
.createWithDefaultString("600s")
+ val CLIENT_FETCH_BUFFER_MAX_SIZE: ConfigEntry[Long] =
+ buildConf("celeborn.client.fetch.buffer.max.size")
+ .categories("client")
+ .version("0.4.0")
+ .doc("Max size of reducer partition buffer memory for shuffle reader.")
Review Comment:
Could you add more detail for this config like
`celeborn.client.push.buffer.max.size` to tell user how to configure the
reasonable config value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
