FMX commented on code in PR #2119:
URL:
https://github.com/apache/incubator-celeborn/pull/2119#discussion_r1411768474
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -674,15 +674,11 @@ private[celeborn] class Master(
else Math.min(slotsAssignMaxWorkers, requestSlots.maxWorkers)),
numAvailableWorkers)
val startIndex = Random.nextInt(numAvailableWorkers)
Review Comment:
Duplicating the available workers' array might be a problem. Worker numbers
in different environments might vary. We can not assume that the worker number
won't be large.
We treated `availableWorkers` as a Circular Queue. If the old codes are not
easy to read, maybe add some comments could be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
