waitinfuture commented on code in PR #2131:
URL: 
https://github.com/apache/incubator-celeborn/pull/2131#discussion_r1422086857


##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1241,7 +1245,8 @@ class LifecycleManager(val appUniqueId: String, val conf: 
CelebornConf) extends
         pushRackAwareEnabled,
         userIdentifier,
         slotsAssignMaxWorkers,
-        availableStorageTypes)
+        availableStorageTypes,
+        workerStatusTracker.excludedWorkers.asScala.keys.toSet)

Review Comment:
   I think we'd better add a config to enable this feature to avoid the corner 
case where most of the workers are excluded.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to