FMX commented on code in PR #2130:
URL:
https://github.com/apache/incubator-celeborn/pull/2130#discussion_r1434782208
##########
common/src/test/scala/org/apache/celeborn/common/util/PbSerDeUtilsTest.scala:
##########
@@ -138,10 +149,11 @@ class PbSerDeUtilsTest extends CelebornFunSuite {
val pbFileInfo = PbSerDeUtils.toPbFileInfo(fileInfo1)
val restoredFileInfo = PbSerDeUtils.fromPbFileInfo(pbFileInfo)
- assert(restoredFileInfo.getFilePath.equals(fileInfo1.getFilePath))
- assert(restoredFileInfo.getChunkOffsets.equals(fileInfo1.getChunkOffsets))
+ assert(
+ restoredFileInfo.getFilePath.equals(fileInfo1.getFilePath))
+ assert(restoredFileInfo.getChunkOffsets.equals(
+ fileInfo1.getChunkOffsets))
assert(restoredFileInfo.getUserIdentifier.equals(fileInfo1.getUserIdentifier))
-
assert(restoredFileInfo.getPartitionType.equals(fileInfo1.getPartitionType))
Review Comment:
PartitionType is removed from fileinfo and can be retrieved from FileMeta.
So in this test case, there is no partitionType.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
