waitinfuture commented on code in PR #2196:
URL:
https://github.com/apache/incubator-celeborn/pull/2196#discussion_r1438952013
##########
client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SortBasedShuffleWriter.java:
##########
@@ -189,28 +156,13 @@ public SortBasedShuffleWriter(
conf,
client,
metrics,
- executorService,
sendBufferPool);
}
private void updatePeakMemoryUsed() {
- // sorter can be null if this writer is closed
- if (pipelined) {
- for (SortBasedPusher pusher : pushers) {
- if (pusher != null) {
- long mem = pusher.getPeakMemoryUsedBytes();
- if (mem > peakMemoryUsedBytes) {
- peakMemoryUsedBytes = mem;
- }
- }
- }
- } else {
- if (currentPusher != null) {
Review Comment:
I think it's safe to remove this null check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
