waitinfuture commented on code in PR #2194:
URL:
https://github.com/apache/incubator-celeborn/pull/2194#discussion_r1440404979
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2418,6 +2420,22 @@ object CelebornConf extends Logging {
.intConf
.createOptional
+ val PARTITION_SORTER_INDEX_CACHE_MAX_WEIGHT: ConfigEntry[Long] =
+ buildConf("celeborn.worker.sortPartition.indexCache.maxWeight")
+ .categories("worker")
+ .doc("PartitionSorter's cache max weight for index buffer.")
+ .version("0.4.1")
+ .bytesConf(ByteUnit.BYTE)
+ .createWithDefaultString("10m")
Review Comment:
Since weight is now the total number of `ShuffleBlockInfo`s, it's
unreasonable to use bytes here. Better to use long and default to say 10000.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
