waitinfuture commented on code in PR #2207:
URL:
https://github.com/apache/incubator-celeborn/pull/2207#discussion_r1443765472
##########
client/src/main/scala/org/apache/celeborn/client/ChangePartitionManager.scala:
##########
@@ -144,7 +183,13 @@ class ChangePartitionManager(
oldPartition,
cause)
// check if there exists request for the partition, if do just register
- val requests = changePartitionRequests.computeIfAbsent(shuffleId,
rpcContextRegisterFunc)
+ val requests =
+ if (!batchHandleChangePartitionEnabled) {
+ changePartitionRequests.computeIfAbsent(shuffleId,
rpcContextRegisterFunc)
+ } else {
+ changePartitionRequests.computeIfAbsent(shuffleId,
rpcContextRegisterFunc)
+ pendingChangePartitionRequests.computeIfAbsent(shuffleId,
rpcContextRegisterFunc)
Review Comment:
Seems `changePartitionRequests` will never add change partition requests
##########
client/src/main/scala/org/apache/celeborn/client/ChangePartitionManager.scala:
##########
@@ -81,6 +84,42 @@ class ChangePartitionManager(
new Runnable {
override def run(): Unit = {
requests.synchronized {
+ // Move all pending requests to requests
+
pendingChangePartitionRequests.get(shuffleId).synchronized {
Review Comment:
Since `changePartitionRequests` will not add change partition requests, do
we really want `pendingChangePartitionRequests`? Maybe we can just add the
checking latest partition logic in original code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
