FMX commented on code in PR #2119:
URL:
https://github.com/apache/incubator-celeborn/pull/2119#discussion_r1454993815
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -678,16 +679,9 @@ private[celeborn] class Master(
if (requestSlots.maxWorkers <= 0) slotsAssignMaxWorkers
else Math.min(slotsAssignMaxWorkers, requestSlots.maxWorkers)),
numAvailableWorkers)
- val startIndex = Random.nextInt(numAvailableWorkers)
- val selectedWorkers = new util.ArrayList[WorkerInfo](numWorkers)
- selectedWorkers.addAll(availableWorkers.subList(
- startIndex,
- Math.min(numAvailableWorkers, startIndex + numWorkers)))
- if (startIndex + numWorkers > numAvailableWorkers) {
- selectedWorkers.addAll(availableWorkers.subList(
- 0,
- startIndex + numWorkers - numAvailableWorkers))
- }
+ Collections.rotate(availableWorkers, Random.nextInt(numAvailableWorkers))
+ val selectedWorkers = availableWorkers.subList(0, numWorkers)
+
// offer slots
val slots =
Review Comment:
@mridulm I think there is no problem because the workers' snapshot is a new
list.
```java
private def workersSnapShot: util.List[WorkerInfo] =
statusSystem.workers.synchronized(new
util.ArrayList[WorkerInfo](statusSystem.workers))
```
And the extra workers are selected from those workers who not participated
in this shuffle.
```java
val workersNotSelected =
availableWorkers.asScala.filter(!slots.containsKey(_))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
