AngersZhuuuu commented on code in PR #2241:
URL:
https://github.com/apache/incubator-celeborn/pull/2241#discussion_r1457382568
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportResponseHandler.java:
##########
@@ -86,7 +86,8 @@ public TransportResponseHandler(TransportConf conf, Channel
channel) {
if (TransportModuleConstants.DATA_MODULE.equals(module)) {
checkPushTimeout = true;
checkFetchTimeout = true;
- } else if (TransportModuleConstants.PUSH_MODULE.equals(module)) {
+ } else if
(TransportModuleConstants.PUSH_MODULE.equals(conf.getModuleName())
+ ||
TransportModuleConstants.REPLICATE_MODULE.equals(conf.getModuleName())) {
Review Comment:
Just use `module`?
##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportResponseHandler.java:
##########
@@ -141,7 +142,8 @@ public void failExpiredPushRequest() {
// do data replication.
if
(TransportModuleConstants.DATA_MODULE.equals(conf.getModuleName())) {
info.callback.onFailure(new
CelebornIOException(StatusCode.PUSH_DATA_TIMEOUT_PRIMARY));
- } else if
(TransportModuleConstants.PUSH_MODULE.equals(conf.getModuleName())) {
+ } else if
(TransportModuleConstants.PUSH_MODULE.equals(conf.getModuleName())
+ ||
TransportModuleConstants.REPLICATE_MODULE.equals(conf.getModuleName())) {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
