AngersZhuuuu commented on code in PR #2229:
URL:
https://github.com/apache/incubator-celeborn/pull/2229#discussion_r1458230638
##########
client/src/main/java/org/apache/celeborn/client/write/DataPusher.java:
##########
@@ -137,6 +138,7 @@ public void run() {
}
};
pushThread.setDaemon(true);
+ pushThread.setUncaughtExceptionHandler(new
ThreadExceptionHandler("DataPusher-" + taskId));
pushThread.start();
Review Comment:
Since pushThread need call join, so won't change here.
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/Flusher.scala:
##########
@@ -125,23 +120,6 @@ abstract private[worker] class Flusher(
workingQueues(workerIndex).offer(task, timeoutMs, TimeUnit.MILLISECONDS)
}
- def bufferQueueInfo(): String = s"$this used buffers: ${bufferQueue.size()}"
-
- def stopAndCleanFlusher(): Unit = {
- stopFlag.set(true)
- try {
- workers.foreach(_.interrupt())
- } catch {
- case e: Exception =>
- logError(s"Exception when interrupt worker: ${workers.mkString(",")},
$e")
- }
- workingQueues.foreach { queue =>
- queue.asScala.foreach { task =>
- returnBuffer(task.buffer)
- }
- }
- }
-
Review Comment:
Code not used.
##########
client/src/main/java/org/apache/celeborn/client/write/DataPusher.java:
##########
@@ -137,6 +138,7 @@ public void run() {
}
};
pushThread.setDaemon(true);
+ pushThread.setUncaughtExceptionHandler(new
ThreadExceptionHandler("DataPusher-" + taskId));
Review Comment:
Since pushThread need call join, so won't change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
