AngersZhuuuu commented on code in PR #2337:
URL:
https://github.com/apache/incubator-celeborn/pull/2337#discussion_r1503952480
##########
service/src/main/java/org/apache/celeborn/server/common/service/config/FsConfigServiceImpl.java:
##########
@@ -87,14 +87,14 @@ private Map<String, String> getConfigs(Map<String, Object>
configMap) {
private File getConfigFile(Map<String, String> env) throws IOException {
Review Comment:
What if we want set quota in a separated file?
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -4458,6 +4459,14 @@ object CelebornConf extends Logging {
.timeConf(TimeUnit.MILLISECONDS)
.createWithDefaultString("120s")
+ val DYNAMIC_CONFIG_STORE_FS_PATH: OptionalConfigEntry[String] =
+ buildConf("celeborn.dynamicConfig.store.fs.path")
+ .categories("master", "worker")
+ .version("0.5.0")
+ .doc("The path of dynamic config file for fs store backend.")
Review Comment:
Should we explain that if we didn't set it, will use
`$CELEBORN_CONF/dynamicConfig.yaml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
