waitinfuture commented on PR #2335: URL: https://github.com/apache/incubator-celeborn/pull/2335#issuecomment-1966206151
> > additionally, conditional mapping spark internal configuration may involve a lot of inconsistency. for example, should we map `spark.shuffle.service.port` to celeborn's something? due the different implementation details, Celeborn won't benefit from zstd buffer pool feature, if we map `spark.io.compression.codec` to `celeborn.shuffle.compression.codec`, how could the user know that `spark.io.compression.zstd.bufferPool.enabled` does not take effect? > > Make sense! So should we add some logs to show that spark.shuffle.xxx will not take effect when using celeborn? Thanks @JinHelin404 for looking into this. Another reason why Celeborn doesn't automatically map Spark's configuration is that Celeborn supports multiple engines (i.e. Spark, Flink, MR, MR3), it unreasonable to respect a particular engine's configuration :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
