AngersZhuuuu commented on code in PR #2342:
URL:
https://github.com/apache/incubator-celeborn/pull/2342#discussion_r1505327080
##########
master/src/main/scala/org/apache/celeborn/service/deploy/master/Master.scala:
##########
@@ -1024,13 +994,12 @@ private[celeborn] class Master(
}
}
+ // TODO: Support calculate topN app resource consumption.
private def computeUserResourceConsumption(
userIdentifier: UserIdentifier): ResourceConsumption = {
- val (resourceConsumption, subResourceConsumptions) =
statusSystem.workers.asScala.flatMap {
+ val resourceConsumption = statusSystem.workers.asScala.flatMap {
workerInfo =>
workerInfo.userResourceConsumption.asScala.get(userIdentifier)
- }.foldRight((ResourceConsumption(0, 0, 0, 0), Map.empty[String,
ResourceConsumption]))(
- _ addWithSubResourceConsumptions _)
- resourceConsumption.subResourceConsumptions =
subResourceConsumptions.asJava
+ }.foldRight(ResourceConsumption(0, 0, 0, 0))(_ add _)
Review Comment:
Remove calculate sub resource consumption since 90%+ cpu in this
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala:
##########
@@ -538,10 +538,6 @@ private[celeborn] class Worker(
workerInfo.updateThenGetUserResourceConsumption(resourceConsumptionSnapshot.asJava)
resourceConsumptionSnapshot.foreach { case (userIdentifier,
userResourceConsumption) =>
gaugeResourceConsumption(userIdentifier)
- val subResourceConsumptions =
userResourceConsumption.subResourceConsumptions
- if (CollectionUtils.isNotEmpty(subResourceConsumptions)) {
- subResourceConsumptions.asScala.keys.foreach {
gaugeResourceConsumption(userIdentifier, _) }
- }
Review Comment:
Remove app level metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
