SteNicholas commented on code in PR #2361: URL: https://github.com/apache/incubator-celeborn/pull/2361#discussion_r1515393727
########## web/src/views/overview/components/StorageOverview.vue: ########## @@ -0,0 +1,46 @@ +<!-- +* Licensed to the Apache Software Foundation (ASF) under one +* or more contributor license agreements. See the NOTICE file +* distributed with this work for additional information +* regarding copyright ownership. The ASF licenses this file +* to you under the Apache License, Version 2.0 (the +* "License"); you may not use this file except in compliance +* with the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +--> + +<template> + <n-card hoverable> + <n-descriptions label-placement="left" title="Storage Usage Infos"> + <n-descriptions-item label="disk"> {{ data.diskUsage }} </n-descriptions-item> + <n-descriptions-item label="memory"> Review Comment: ```suggestion <n-descriptions-item label="Memory"> ``` ########## web/src/views/overview/components/WorkerOverview.vue: ########## @@ -0,0 +1,43 @@ +<!-- +* Licensed to the Apache Software Foundation (ASF) under one +* or more contributor license agreements. See the NOTICE file +* distributed with this work for additional information +* regarding copyright ownership. The ASF licenses this file +* to you under the Apache License, Version 2.0 (the +* "License"); you may not use this file except in compliance +* with the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +--> + +<template> + <n-card hoverable> + <n-descriptions label-placement="left" title="Worker State Nums"> + <n-descriptions-item label="Decommission"> {{ data.decommissionNum }} </n-descriptions-item> Review Comment: Add the normal num in `Worker State Nums`: ``` <n-descriptions-item label="Normal"> {{ data.normalNum }} </n-descriptions-item> ``` ########## web/vite.config.ts: ########## @@ -25,6 +25,18 @@ import { NaiveUiResolver } from 'unplugin-vue-components/resolvers' // https://vitejs.dev/config/ export default defineConfig({ + // FIXME: Get the real service address and then change it Review Comment: ```suggestion // TODO: Get the backend service address and then change this uri. ``` ########## web/src/views/overview/components/StorageOverview.vue: ########## @@ -0,0 +1,46 @@ +<!-- +* Licensed to the Apache Software Foundation (ASF) under one +* or more contributor license agreements. See the NOTICE file +* distributed with this work for additional information +* regarding copyright ownership. The ASF licenses this file +* to you under the Apache License, Version 2.0 (the +* "License"); you may not use this file except in compliance +* with the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +--> + +<template> + <n-card hoverable> + <n-descriptions label-placement="left" title="Storage Usage Infos"> + <n-descriptions-item label="disk"> {{ data.diskUsage }} </n-descriptions-item> + <n-descriptions-item label="memory"> + {{ data.memoryUsage }} + </n-descriptions-item> + <n-descriptions-item label="hdfs"> Review Comment: ```suggestion <n-descriptions-item label="HDFS"> ``` ########## web/src/views/overview/components/StorageOverview.vue: ########## @@ -0,0 +1,46 @@ +<!-- +* Licensed to the Apache Software Foundation (ASF) under one +* or more contributor license agreements. See the NOTICE file +* distributed with this work for additional information +* regarding copyright ownership. The ASF licenses this file +* to you under the Apache License, Version 2.0 (the +* "License"); you may not use this file except in compliance +* with the License. You may obtain a copy of the License at +* +* http://www.apache.org/licenses/LICENSE-2.0 +* +* Unless required by applicable law or agreed to in writing, software +* distributed under the License is distributed on an "AS IS" BASIS, +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +* See the License for the specific language governing permissions and +* limitations under the License. +--> + +<template> + <n-card hoverable> + <n-descriptions label-placement="left" title="Storage Usage Infos"> + <n-descriptions-item label="disk"> {{ data.diskUsage }} </n-descriptions-item> Review Comment: ```suggestion <n-descriptions-item label="Disk"> {{ data.diskUsage }} </n-descriptions-item> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
