CodingCat commented on code in PR #2358:
URL:
https://github.com/apache/incubator-celeborn/pull/2358#discussion_r1519763470
##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala:
##########
@@ -697,6 +697,10 @@ private[deploy] class Controller(
val releaseReplicaLocations =
partitionLocationInfo.removeReplicaPartitions(shuffleKey,
replicaLocations)
workerInfo.releaseSlots(shuffleKey, releaseReplicaLocations._1)
+ workerSource.incCounter(
+ WorkerSource.SLOTS_ALLOCATED,
+ -(primaryLocations.size() + replicaLocations.size() -
failedPrimaries.size()
Review Comment:
oops, I will remove this, this is something I always working on...BTW, I
think we should decrease it properly otherwise, I don't feel this metrics
conveys too much information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
