mridulm commented on code in PR #2446:
URL: https://github.com/apache/celeborn/pull/2446#discussion_r1552643906
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/HARaftServer.java:
##########
@@ -163,6 +166,8 @@ public static HARaftServer newMasterRatisServer(
.setId(localRaftPeerId)
.setAddress(ratisAddr)
.setClientAddress(localNode.rpcEndpoint())
+ // We use admin address to host the internal rpc address
+ .setAdminAddress(localNode.internalRpcEndpoint())
Review Comment:
Note to reviewers - I am using `setAdminAddress` as a mechanism to store the
internal rpc endpoint - I am not very familiar with ratis, please do validate
if this is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]