mridulm commented on code in PR #2373:
URL: https://github.com/apache/celeborn/pull/2373#discussion_r1562078042
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -135,30 +136,37 @@ protected Compressor initialValue() {
private final ReviveManager reviveManager;
+ private final boolean dataPushFailureTrackingEnabled;
+
protected static class ReduceFileGroups {
public Map<Integer, Set<PartitionLocation>> partitionGroups;
+ public Map<String, Set<PushFailedBatch>> pushFailedBatches;
Review Comment:
QQ: This is essentially relevant only when hard_split's happen, right ?
For all other cases, either we retry and it succeeds or task fails ?
I want to make sure I am not missing some other cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
