SteNicholas opened a new pull request, #2457: URL: https://github.com/apache/celeborn/pull/2457
### What changes were proposed in this pull request? Gauge `is_terminating`, `is_terminated` and `is_shutdown` should represent a single numerical value instead of boolean value. ### Why are the changes needed? A gauge is a metric that represents a single numerical value that can arbitrarily go up and down. The value type of `is_terminating`, `is_terminated` and `is_shutdown` should be numerical, otherwise `AbstractSource#addGauge` would warn the failed log as follows: ``` 2024-04-12 20:04:12,387 [WARN] [main] - org.apache.celeborn.common.metrics.source.JVMSource -Logging.scala(55) -Add gauge jvm.thread.deadlocks failed, the value type class java.util.Collections$EmptySet is not a number 2024-04-12 20:04:12,438 [WARN] [main] - org.apache.celeborn.common.metrics.source.ThreadPoolSource -Logging.scala(55) -Add gauge is_terminating failed, the value type class java.lang.Boolean is not a number 2024-04-12 20:04:12,438 [WARN] [main] - org.apache.celeborn.common.metrics.source.ThreadPoolSource -Logging.scala(55) -Add gauge is_terminated failed, the value type class java.lang.Boolean is not a number 2024-04-12 20:04:12,438 [WARN] [main] - org.apache.celeborn.common.metrics.source.ThreadPoolSource -Logging.scala(55) -Add gauge is_shutdown failed, the value type class java.lang.Boolean is not a number ``` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
