FMX commented on code in PR #2458:
URL: https://github.com/apache/celeborn/pull/2458#discussion_r1566650675
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java:
##########
@@ -114,6 +121,19 @@ public static org.rocksdb.RocksDB initRockDB(File dbFile,
StoreVersion version)
return tmpDb;
}
+ private static void createIfMissing(Options dbOptions, File dbFile) {
Review Comment:
Maybe move this method to a class named DBUtils will be better.
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java:
##########
@@ -93,6 +93,19 @@ public static org.iq80.leveldb.DB initLevelDB(File dbFile,
StoreVersion version)
return tmpDb;
}
+ private static void createIfMissing(Options dbOptions, File dbFile) {
Review Comment:
This method looks similar to the same method in RocksDBProvider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
