FMX commented on code in PR #2460:
URL: https://github.com/apache/celeborn/pull/2460#discussion_r1568171139
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -167,6 +231,11 @@ class CelebornConf(loadDefaults: Boolean) extends
Cloneable with Logging with Se
Utils.timeStringAsSeconds(get(key, defaultValue))
}
+ /** Get time in seconds for a transport config */
+ def getTransportConfTimeAsSeconds(module: String, configEntry:
ConfigEntry[Long]): Long = {
Review Comment:
This method is not used.
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -309,6 +408,11 @@ class CelebornConf(loadDefaults: Boolean) extends
Cloneable with Logging with Se
getOption(key).map(_.toLong).getOrElse(defaultValue)
}
+ /** Get a parameter as a long for a transport config */
+ def getTransportConfLong(module: String, configEntry: ConfigEntry[Long]):
Long = {
Review Comment:
ditto.
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -251,6 +335,11 @@ class CelebornConf(loadDefaults: Boolean) extends
Cloneable with Logging with Se
Utils.byteStringAsMb(get(key, defaultValue))
}
+ /** Get a size parameter as mb for a transport config */
+ def getTransportConfSizeAsMb(module: String, configEntry:
ConfigEntry[Long]): Long = {
Review Comment:
This method is not used too, I think adding a new method in time will be
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
