waitinfuture commented on code in PR #2462:
URL: https://github.com/apache/celeborn/pull/2462#discussion_r1571656141
##########
client/src/main/scala/org/apache/celeborn/client/ChangePartitionManager.scala:
##########
@@ -79,14 +81,18 @@ class ChangePartitionManager(
batchHandleChangePartitionExecutors.submit {
new Runnable {
override def run(): Unit = {
- val distinctPartitions = requests.synchronized {
- // For each partition only need handle one request
- requests.asScala.filter { case (partitionId, _) =>
-
!inBatchPartitions.get(shuffleId).contains(partitionId)
- }.map { case (partitionId, request) =>
- inBatchPartitions.get(shuffleId).add(partitionId)
- request.asScala.toArray.maxBy(_.epoch)
- }.toArray
+ val distinctPartitions = {
+ val requestSet = inBatchPartitions.get(shuffleId)
+ requests.asScala.map { case (partitionId, request) =>
+ locks(partitionId % locks.length).synchronized {
+ if (!inBatchPartitions.contains(partitionId)) {
Review Comment:
Do you mean `requestSet.contains(partitionId)` here?
Since `requestSet` is just `util.HashSet`, it's not thread safe. Multiple
threads can concurrently modify`requestSet` if they are processing different
partition ids, which I think may cause undefined behavior.
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -3899,6 +3901,14 @@ object CelebornConf extends Logging {
.booleanConf
.createWithDefault(true)
+ val CLIENT_BATCH_HANDLE_CHANGE_PARTITION_PARALLELISM: ConfigEntry[Int] =
+ buildConf("celeborn.client.shuffle.batchHandleChangePartition.parallelism")
Review Comment:
Maybe `celeborn.client.shuffle.batchHandleChangePartition.partitionBuckets`
is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
