mridulm commented on code in PR #2469:
URL: https://github.com/apache/celeborn/pull/2469#discussion_r1572786628
##########
common/src/main/java/org/apache/celeborn/common/network/TransportContext.java:
##########
@@ -209,17 +209,27 @@ public TransportChannelHandler initializePipeline(
private SSLFactory createSslFactory() {
if (conf.sslEnabled()) {
+
Review Comment:
Given how the code has evolved, we dont even need to special case
`!autoSslEnabled` here.
Earlier, I was creating the self-signed certificate at this place; but now
that it has been moved to `SSLFactory`, this is not required.
Thanks for pointing this out !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
