ChenYi015 commented on code in PR #2470:
URL: https://github.com/apache/celeborn/pull/2470#discussion_r1574072225
##########
charts/celeborn/templates/master-statefulset.yaml:
##########
@@ -20,21 +20,13 @@ kind: StatefulSet
metadata:
name: {{ .Release.Name }}-master
labels:
- helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version }}
- app.kubernetes.io/name: {{ .Chart.Name }}
- app.kubernetes.io/instance: {{ .Release.Name }}
- app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
- app.kubernetes.io/managed-by: {{ .Release.Service }}
- app.kubernetes.io/role: master
{{- include "celeborn.labels" . | nindent 4 }}
+ app.kubernetes.io/role: master
spec:
selector:
matchLabels:
- app.kubernetes.io/name: {{ .Chart.Name }}
- app.kubernetes.io/instance: {{ .Release.Name }}
- app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
- app.kubernetes.io/role: master
{{- include "celeborn.selectorLabels" . | nindent 6 }}
Review Comment:
When creating a new Helm chart, the default `selectorLabels` should include
only `app.kubernetes.io/name` and `app.kubernetes.io/instance`, as these are
sufficient for distinguishing between different deployments of the chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
